Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(buttons): display correct NgModel value inside OnPush component #3000

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

maxokorokov
Copy link
Member

In short, the problem is that ngModel updates to the real value in the resolved promise, so we have to force mark for check all radios/checkboxes. Otherwise parent component with OnPush will prevent it.

Fixes #2980

@codecov-io
Copy link

Codecov Report

Merging #3000 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3000      +/-   ##
==========================================
+ Coverage   92.26%   92.27%   +<.01%     
==========================================
  Files          91       91              
  Lines        2870     2873       +3     
  Branches      463      464       +1     
==========================================
+ Hits         2648     2651       +3     
  Misses        163      163              
  Partials       59       59
Flag Coverage Δ
#e2e 60.04% <0%> (-0.07%) ⬇️
#unit 90.65% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/buttons/checkbox.ts 100% <100%> (ø) ⬆️
src/buttons/radio.ts 95.08% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932d7f6...aa72873. Read the comment docs.

Copy link
Member

@benouat benouat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. Please proceed with merge

@maxokorokov maxokorokov merged commit 083fb0f into ng-bootstrap:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(buttons): pre-checked value doesn't work with ChangeDetectionStrategy.OnPush
3 participants