Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): arrow positioning issues #3006

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

fbasso
Copy link
Member

@fbasso fbasso commented Feb 7, 2019

fix #2089

@fbasso
Copy link
Member Author

fbasso commented Feb 7, 2019

By the way, this PR will fix #2234, regarding the arrow positioning. The remaining fix must be done with container="body", as popover in popover is not supported with Bootstrap.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Will merge when Travis is green

@codecov-io
Copy link

Codecov Report

Merging #3006 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3006   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          91       91           
  Lines        2822     2822           
  Branches      451      451           
=======================================
  Hits         2607     2607           
  Misses        162      162           
  Partials       53       53
Flag Coverage Δ
#e2e 60.63% <ø> (ø) ⬆️
#unit 90.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d5716...79e9753. Read the comment docs.

@maxokorokov maxokorokov merged commit a613fa9 into ng-bootstrap:master Feb 7, 2019
@fbasso fbasso deleted the popover-arrow branch February 7, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Position of popover is slightly shifted (again)
3 participants