Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker: NgbCalendarGregorian is not in public api. #3054

Closed
itayod opened this issue Mar 6, 2019 · 2 comments
Closed

Date Picker: NgbCalendarGregorian is not in public api. #3054

itayod opened this issue Mar 6, 2019 · 2 comments

Comments

@itayod
Copy link

itayod commented Mar 6, 2019

Bug description:

Hi, I am trying to use the NgbCalendarGregorian, but it seems to not be in your public api.
I need to use this class for a factory method that need to return MyCustomCalendar or NgbCalendarGregorian (as the default calendar).

I will be glad if it will be part of the public api or maybe show me some work around that I have maybe missed.

p.s. I will be happy to create a pr for it 😄

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 7.2.5

ng-bootstrap: 4.0.2

@maxokorokov
Copy link
Member

NgbCalendarGregorian is the one used by default, so you shouldn't do anything special to use it. But this is definitely an omission, we should add it to public exports in src/index.ts and src/datepicker/datepicker.module.ts

@maxokorokov maxokorokov added this to the 4.1.1 milestone Mar 13, 2019
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Mar 13, 2019
@itayod
Copy link
Author

itayod commented Mar 13, 2019

Thank you @maxokorokov ,

Actually I am using it inside a factory method that should return CustomCalendar or the default calendar,
and also my CustomCalendar extends NgbCalendarGregorian.

Anyway thanks for the quick fix 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants