Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker is displayed behind Modal if datepicker container is set to body #3133

Closed
llRandom opened this issue Apr 20, 2019 · 1 comment · Fixed by #3158
Closed

DatePicker is displayed behind Modal if datepicker container is set to body #3133

llRandom opened this issue Apr 20, 2019 · 1 comment · Fixed by #3158
Labels
component: datepicker type: bug
Milestone
4.1.2

Comments

@llRandom
Copy link

Bug description:

NgbDatePicker is displayed behind NgbModal if datepicker container is set to body

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-d5kbff

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 7.3.8

ng-bootstrap: 4.1.1

Bootstrap: 4.3.1
@maxokorokov
Copy link
Member

@llRandom, bootstrap's modal has a z-index of 1050 by default (could be changed with theming)

We don't set any z-index values currently on the datepicker, but we should.
I guess it should be either the same as modal (1050), or as a tooltip (1070)

Related to #2686 and #2947

cc @fbasso

@maxokorokov maxokorokov added this to the 4.1.2 milestone Apr 24, 2019
@maxokorokov maxokorokov mentioned this issue Apr 24, 2019
Closed
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Apr 30, 2019
@maxokorokov
fix(datepicker): z-index set when appended to body
93fa23f 
Fixes ng-bootstrap#3133
@maxokorokov maxokorokov mentioned this issue Apr 30, 2019
Merged
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Apr 30, 2019
@maxokorokov
fix(datepicker): z-index set when appended to body
1feebfc 
Fixes ng-bootstrap#3133
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Apr 30, 2019
@maxokorokov
fix(datepicker): z-index set when appended to body
219da38 
Fixes ng-bootstrap#3133
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Apr 30, 2019
@maxokorokov
fix(datepicker): z-index set when appended to body
d322b44 
Fixes ng-bootstrap#3133
maxokorokov added a commit that referenced this issue Apr 30, 2019
@maxokorokov
fix(datepicker): z-index set when appended to body
00ee594 
Fixes #3133
@HexagonSun HexagonSun mentioned this issue Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: datepicker type: bug
Projects
None yet
Milestone
4.1.2
Development

Successfully merging a pull request may close this issue.

fix(datepicker): z-index set when appended to body maxokorokov/ng-bootstrap
2 participants
@llRandom @maxokorokov