Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown does not conform to ARIA authoring practices #3331

Closed
divyanshumehta opened this issue Aug 20, 2019 · 5 comments · Fixed by #3339
Closed

Dropdown does not conform to ARIA authoring practices #3331

divyanshumehta opened this issue Aug 20, 2019 · 5 comments · Fixed by #3339
Labels
component: dropdown type: accessibility
Projects
Accessibility

Comments

@divyanshumehta
Copy link
Contributor

divyanshumehta commented Aug 20, 2019 •
edited

TL;DR - Remove aria-haspop="true" from dropdown component

Bug description:

Please follow the link to find the details of how the current Dropdown componet does not conform to ARIA practices.
twbs/bootstrap#28295

I think ng-bootsrap dropdowns should also be in line with this as it causes a great loss in accessibility.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 6.1.0

ng-bootstrap: 4.0.0

Bootstrap: 4.3.1
@divyanshumehta
Copy link
Contributor Author

divyanshumehta commented Aug 23, 2019 •
edited

Hey @benouat can I go ahead and take up and fix the issue?

@benouat
Copy link
Member

benouat commented Aug 23, 2019

Of course ! Please be our guest. Open a PR, we'll review it and merge it.

Contributions of any kind are always welcome!

@divyanshumehta divyanshumehta mentioned this issue Aug 24, 2019
Merged
@scavoola
Copy link

scavoola commented Sep 2, 2019

Just a note that I have the latest versions installed and am having trouble on the iPad and iPhone when using a dropdown that I have to hold the touch down on the dropdown-item for it to select the item. If I touch and release too quickly it does not fire the 'click'. I am wondering if it is related to this issue.
I will test after this PR has been released and raise an issue at that stage if I still have a problem.
thanks for the good work.

@divyanshumehta
Copy link
Contributor Author

@scavoola No this issue does not seem to be related to your issue. Go ahead and open a new issue.

@scavoola
Copy link

scavoola commented Sep 2, 2019

ok thanks for the quick response divyanshumehta

@benouat benouat added this to To Do in Accessibility May 28, 2020
@benouat benouat moved this from To Do to Needs Refactor in Accessibility May 28, 2020
benouat pushed a commit that referenced this issue Jul 9, 2020
@divyanshumehta
fix(dropdown): remove aria-haspopup for accessibility (#3339)
0c92e39 
Closes #3331

To remove aria-haspopup from the dropdown component to allow the component to
be read by screen reader like NVDA/JAWS. To make the dropdown component
more accessible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dropdown type: accessibility
Projects
Accessibility
  
Needs Refactor
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dropdown): remove aria-haspop for accessibility
3 participants
@benouat @divyanshumehta @scavoola