-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version is not compatible with noImplicitAny #3464
Milestone
Comments
@nseni I guess the workaround for you should be... adding a type :) I think this works for me: const modalRef: NgbModalRef<typeof NgbdModalContent> But we broke it in a patch |
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this issue
Jan 3, 2020
…ootstrap#2815) This reverts commit f450a7c Fixes ng-bootstrap#3464
Closed
gentoo90
added a commit
to gentoo90/ng-bootstrap
that referenced
this issue
Feb 9, 2020
gentoo90
added a commit
to gentoo90/ng-bootstrap
that referenced
this issue
Feb 9, 2020
5 tasks
@maxokorokov Oh, no. You broke my type usage, now I cannot upgrade, it says |
gentoo90
added a commit
to gentoo90/ng-bootstrap
that referenced
this issue
Apr 19, 2021
gentoo90
added a commit
to gentoo90/ng-bootstrap
that referenced
this issue
Jan 30, 2022
gentoo90
added a commit
to gentoo90/ng-bootstrap
that referenced
this issue
Oct 17, 2023
gentoo90
added a commit
to gentoo90/ng-bootstrap
that referenced
this issue
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To reproduce:
npm install
ng build
. No errors ✔️tsconfig.json
: add"noImplicitAny": true,
tocompilerOptions
ng build
. Build fails ❌Error:
npm i @ng-bootstrap/ng-bootstrap@5.1.1
ng build
. No errors ✔️The error is caused by this code:
Which was originally inspired by #2904 (comment)
The text was updated successfully, but these errors were encountered: