Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover arrows missing after 6.0.1 #3653

Closed
stedel opened this issue Mar 23, 2020 · 3 comments · Fixed by #3655
Closed

Popover arrows missing after 6.0.1 #3653

stedel opened this issue Mar 23, 2020 · 3 comments · Fixed by #3655

Comments

@stedel
Copy link

stedel commented Mar 23, 2020

Bug description:

6.0.1 seems to break Popover arrows pointing to the attached element.
6.0.1 seems to still apply the class, as the border, where the arrow should be, is different from the rest of the popover, when the placement is set to right or left.
6.0.0 seems to render the arrow fine.

Link to minimally-working StackBlitz that reproduces the issue:

(both are forked from https://ng-bootstrap.github.io/#/components/popover/examples )
6.0.0 (working arrows): https://stackblitz.com/edit/angular-qzprf6
image

6.0.1 (broken arrows): https://stackblitz.com/edit/angular-feegdc
image

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 9.0.7
ng-bootstrap: 6.0.1
Bootstrap: 4.4.1

@Smoggy
Copy link
Contributor

Smoggy commented Mar 23, 2020

Seems like it's caused by https://github.com/ng-bootstrap/ng-bootstrap/blob/master/src/util/positioning.ts#L150
in order to fix #3640

@maxokorokov
Copy link
Member

Yikes, what a miss... thanks for reporting. Will revert #3644 in 6.0.2

@stedel
Copy link
Author

stedel commented Mar 24, 2020

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants