Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need aria-describedby on modal container #3678

Closed
woehlck opened this issue Apr 15, 2020 · 1 comment · Fixed by #3695
Closed

Need aria-describedby on modal container #3678

woehlck opened this issue Apr 15, 2020 · 1 comment · Fixed by #3695
Labels
component: modal type: accessibility
Milestone
6.1

Comments

@woehlck
Copy link

woehlck commented Apr 15, 2020

Feature request:

This feature request is similar to #2472, but specific to modals. I would like to be able to set the aria-describedby property on a modal in addition to the aria-labelledby property.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 8.1.0

ng-bootstrap: 5.1.0

Bootstrap: 4.3.1
@pkozlowski-opensource
Copy link
Member

Related: #2049

gpolychronis added a commit to gpolychronis/ng-bootstrap that referenced this issue Apr 22, 2020
@gpolychronis
feat(modal): need aria-describedby on modal container (ng-bootstrap#3678
53624e0 
)
@maxokorokov maxokorokov linked a pull request Apr 22, 2020 that will close this issue
feat(modal): need aria-describedby on modal container (#3678) #3695
Merged
5 tasks
@maxokorokov maxokorokov added this to the 6.1 milestone Apr 22, 2020
gpolychronis added a commit to gpolychronis/ng-bootstrap that referenced this issue Apr 22, 2020
@gpolychronis
feat(modal): need aria-describedby on modal container (ng-bootstrap#3678
020e987 
)
maxokorokov pushed a commit that referenced this issue Apr 22, 2020
@gpolychronis
feat(modal): add 'aria-describedby' for modal window (#3695)
9a8e70d 
Fixes #3678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: modal type: accessibility
Projects
None yet
Milestone
6.1
Development

Successfully merging a pull request may close this issue.

feat(modal): need aria-describedby on modal container (#3678) gpolychronis/ng-bootstrap
3 participants
@pkozlowski-opensource @maxokorokov @woehlck