feat(modal): need aria-describedby on modal container (#3678) #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
requested changes
Apr 22, 2020
src/modal/modal-config.ts
Outdated
| /** | ||
| * `aria-describedby` attribute value to set on the modal window. | ||
| * | ||
| * @since 6.0.4 |
There was a problem hiding this comment.
You shouldn't put this, because it is not clear when this will be actually merged.
We're usually adding this only for features, so for X.X.0 releases just before doing the release.
gpolychronis
force-pushed
the
feature/3678
branch
from
53624e0
to
020e987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure you have at least performed the following: