Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional tabs are broken in 8.0.0 #3892

Closed
ghost opened this issue Nov 9, 2020 · 1 comment · Fixed by #3894
Closed

Conditional tabs are broken in 8.0.0 #3892

ghost opened this issue Nov 9, 2020 · 1 comment · Fixed by #3894
Labels
component: nav needs: investigation type: bug
Milestone
8.0.1

Comments

@ghost
Copy link

ghost commented Nov 9, 2020

Bug description:

Conditional tabs (<li [ngbNavItem]="1" *ngIf="canDisplay">) do not display content in version 8.0.0

Link to minimally-working StackBlitz that reproduces the issue:

7.0.0: https://stackblitz.com/edit/angular-twkfgy?file=src%2Fapp%2Fnav-basic.html
8.0.0: https://stackblitz.com/edit/angular-twkfgy-fv3y4b?file=src%2Fapp%2Fnav-basic.html
@maxokorokov maxokorokov added this to the 8.0.1 milestone Nov 9, 2020
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Nov 9, 2020
@maxokorokov
fix(nav): correctly work with conditional nav items
1e879aa 
Fixes a regression in 8.0.0 after the introduction of animations

Fixes ng-bootstrap#3892
@maxokorokov maxokorokov mentioned this issue Nov 9, 2020
Merged
@maxokorokov
Copy link
Member

maxokorokov commented Nov 9, 2020 •
edited
Loading

A couple of things are broken internally with the way active and show classes are set after animations implementation when nav items are shown/hidden. We handled some of dynamic cases, but not all apparently.

I don't think we have quick and easy workarounds for this unfortunately, but this should be fixed in 8.0.1

maxokorokov added a commit that referenced this issue Nov 9, 2020
@maxokorokov
fix(nav): correctly work with conditional nav items (#3894)
1f466ed 
Fixes a regression in 8.0.0 after the introduction of animations

Fixes #3892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: nav needs: investigation type: bug
Projects
None yet
Milestone
8.0.1
Development

Successfully merging a pull request may close this issue.

fix(nav): correctly work with conditional nav items maxokorokov/ng-bootstrap
1 participant
@maxokorokov