Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover event 'shown' is executed outside of angular zone if animation is disabled #3950

Closed
javix opened this issue Jan 15, 2021 · 1 comment · Fixed by #3957
Closed

Popover event 'shown' is executed outside of angular zone if animation is disabled #3950

javix opened this issue Jan 15, 2021 · 1 comment · Fixed by #3957
Labels
component: popover component: tooltip type: animation type: bug
Milestone
9.0.1

Comments

@javix
Copy link

javix commented Jan 15, 2021 •
edited

Bug description:

Popover event 'shown' is executed outside of angular zone if animation is disabled and inside of angular zone if animation is enabled.
I think, all events should be executed INSIDE of angular zone independent of animation.

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-gthjjm?file=src%2Fapp%2Fpopover-triggers.ts
Open the console log.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular:
11.0.9

ng-bootstrap:
8.0.2
9.0.0
@maxokorokov maxokorokov added this to the 9.0.1 milestone Jan 18, 2021
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Jan 19, 2021
@maxokorokov
fix(animations): make sure 'ngbRunTransition' runs inside the zone
c1c1f9a 
Fixes ng-bootstrap#3950
@maxokorokov maxokorokov mentioned this issue Jan 19, 2021
Merged
maxokorokov added a commit that referenced this issue Jan 20, 2021
@maxokorokov
fix(animations): make sure 'ngbRunTransition' runs inside the zone (#…
a29f570 
…3957)

Fixes #3950
maxokorokov added a commit that referenced this issue Jan 21, 2021
@maxokorokov
fix(animations): make sure 'ngbRunTransition' runs inside the zone (#…
a006a62 
…3957)

Fixes #3950

(cherry picked from commit a29f570)
@maxokorokov
Copy link
Member

Fixed in 8.0.3 and 9.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: popover component: tooltip type: animation type: bug
Projects
None yet
Milestone
9.0.1
Development

Successfully merging a pull request may close this issue.

fix(animations): make sure 'ngbRunTransition' runs inside the zone maxokorokov/ng-bootstrap
2 participants
@javix @maxokorokov