Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel ignores [animation]="false" #3961

Closed
maxokorokov opened this issue Jan 20, 2021 · 0 comments · Fixed by #3964
Closed

Carousel ignores [animation]="false" #3961

maxokorokov opened this issue Jan 20, 2021 · 0 comments · Fixed by #3964
Labels
component: carousel type: animation type: bug
Milestone
9.0.1

Comments

@maxokorokov
Copy link
Member

Carousel stays animated even with animations turned off
Checked with 8.0.0 and 9.0.0.
@maxokorokov maxokorokov added this to the 9.0.1 milestone Jan 20, 2021
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Jan 20, 2021
@maxokorokov
fix(carousel): respect [animation]="false"
5c991fa 
Fixes ng-bootstrap#3961
@maxokorokov maxokorokov mentioned this issue Jan 20, 2021
Merged
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Jan 20, 2021
@maxokorokov
fix(carousel): respect [animation]="false"
77a4ff6 
Fixes ng-bootstrap#3961
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Jan 20, 2021
@maxokorokov
fix(carousel): respect [animation]="false"
678ce75 
Fixes ng-bootstrap#3961
maxokorokov added a commit that referenced this issue Jan 21, 2021
@maxokorokov
fix(carousel): respect [animation]="false" (#3964)
175c7ab 
Fixes #3961
maxokorokov added a commit that referenced this issue Jan 21, 2021
@maxokorokov
fix(carousel): respect [animation]="false" (#3964)
9afae34 
Fixes #3961

(cherry picked from commit 175c7ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: carousel type: animation type: bug
Projects
None yet
Milestone
9.0.1
Development

Successfully merging a pull request may close this issue.

fix(carousel): respect [animation]="false" maxokorokov/ng-bootstrap
1 participant
@maxokorokov