Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid aria-activedescendant attribute set on carousel #4014

Closed
twelsh920 opened this issue Feb 19, 2021 · 0 comments
Closed

Invalid aria-activedescendant attribute set on carousel #4014

twelsh920 opened this issue Feb 19, 2021 · 0 comments

Comments

@twelsh920
Copy link

Please remember, the issues forum is NOT for support requests. It is for bugs and feature requests only.
Please read https://github.com/ng-bootstrap/ng-bootstrap/blob/master/CONTRIBUTING.md and search
existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.

Bug description:

The ngb-carousel sets the aria-activedescendant attribute to an invalid id (uses activeId variable when should be using 'slide-'+activeId to match the actual tabpanel ids)

Link to minimally-working StackBlitz that reproduces the issue:

Run a chromium Lighthouse accessibility audit on any page with an ngb-carousel and ngbSlide to see warning

Can even just run audit on https://ng-bootstrap.github.io/#/components/carousel/examples to see the warnings

image

Confirmed that prepending "slide-" to value of aria-activedescendant resolves the issue.

You can fork a StackBlitz from one of our demos and use it as a starting point.

Please note that we can not act on bug reports without a minimal reproduction scenario in a StackBlitz. Here is why:
https://github.com/ng-bootstrap/ng-bootstrap#you-think-youve-found-a-bug

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 11

ng-bootstrap: 9.0.2

Bootstrap: 4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants