Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): missing detectChanges #4075

Merged
merged 1 commit into from
May 12, 2021
Merged

fix(modal): missing detectChanges #4075

merged 1 commit into from
May 12, 2021

Conversation

fbasso
Copy link
Member

@fbasso fbasso commented Apr 21, 2021 •
edited
Loading

fix #3960

@fbasso fbasso force-pushed the modal-open branch 2 times, most recently from 1051c48 to d80b2fd Compare April 22, 2021 12:21
@maxokorokov maxokorokov added this to the 9.1.1 milestone May 12, 2021
maxokorokov
maxokorokov approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maxokorokov maxokorokov merged commit ae2e6b1 into ng-bootstrap:master May 12, 2021
@fbasso fbasso deleted the modal-open branch July 1, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxokorokov maxokorokov maxokorokov approved these changes

Assignees
No one assigned
Labels
component: modal
Projects
None yet
Milestone
9.1.1
Development

Successfully merging this pull request may close these issues.

Adding ngx-drag-scroll to ng-bootstrap modal causes flash while opening modal
2 participants
@fbasso @maxokorokov