You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There seems to be an issue with with carousel indicators not being styled and therefore they do not show at all. After some investigation on my own it seems there is a missing attribute of data-bs-target on the indicator (I personally believe this is a mistake in Bootstrap, but it is what it is) as you see from the snippet here (you can locate this on line 158 - 196 in the _carousel.scss file in the Bootstrap source):
As you can see the attribute data-bs-target is absent. This means that no indicators will show even tough they are styled. Seems like a quick fix to just add the attribute to the template.
Versions of Angular, ng-bootstrap and Bootstrap:
Angular: v13.1.0
ng-bootstrap: v12.0.0-beta.4
Bootstrap: v5.1.3
The text was updated successfully, but these errors were encountered:
- In Bootstrap 5 the CSS selector matching indicators has changed and included `data-bs-target` attribute that we were missing
- Recommended carousel markup changed from using `ul`, `li` and `a` to using `button` elements
- Had to refactor tests as selectors were not precise enough
On Bootstrap side see:
- twbs/bootstrap#32661
- twbs/bootstrap#32627Fixesng-bootstrap#4200Fixesng-bootstrap#4253
- In Bootstrap 5 the CSS selector matching indicators has changed and included `data-bs-target` attribute that we were missing
- Recommended carousel markup changed from using `ul`, `li` and `a` to using `button` elements
- Had to refactor tests as selectors were not precise enough
On Bootstrap side see:
- twbs/bootstrap#32661
- twbs/bootstrap#32627Fixes#4200Fixes#4253
Bug description:
There seems to be an issue with with carousel indicators not being styled and therefore they do not show at all. After some investigation on my own it seems there is a missing attribute of
data-bs-target
on the indicator (I personally believe this is a mistake in Bootstrap, but it is what it is) as you see from the snippet here (you can locate this on line 158 - 196 in the_carousel.scss
file in the Bootstrap source):You can see this in action https://getbootstrap.com/docs/5.1/components/carousel/#with-indicators on the Bootstrap 5 docs.
To replicate this simply create any carousel with 2 or more slides and you will see in ng-bootstrap 12.0.0-beta4 spit out the following result:
As you can see the attribute
data-bs-target
is absent. This means that no indicators will show even tough they are styled. Seems like a quick fix to just add the attribute to the template.Versions of Angular, ng-bootstrap and Bootstrap:
Angular: v13.1.0
ng-bootstrap: v12.0.0-beta.4
Bootstrap: v5.1.3
The text was updated successfully, but these errors were encountered: