Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen Modal bootstrap 5 #4298

Closed
ldavidsp opened this issue Mar 30, 2022 · 1 comment · Fixed by #4314
Closed

Fullscreen Modal bootstrap 5 #4298

ldavidsp opened this issue Mar 30, 2022 · 1 comment · Fixed by #4314

Comments

@ldavidsp
Copy link

ldavidsp commented Mar 30, 2022

Add new size.

 fullscreen
 fullscreen-sm-down
 fullscreen-md-down
 fullscreen-lg-down
 fullscreen-xl-down
 fullscreen-xxl-down

Angular: 13.3.0

ng-bootstrap: 12.0.1

Bootstrap: 5.1

@maxokorokov
Copy link
Member

maxokorokov commented Mar 31, 2022

We should think for a proper API for this maybe, but you can workaround it by using modal options modalDialogClass and adding the modal-fullscreen-XXX class yourself → https://ng-bootstrap.github.io/#/components/modal/api#NgbModalOptions

The decision here is whether we need additional flags for fullscreen in the options object or this would do.
Something like fullscreen: 'sm' | 'md' | 'lg' | 'xl' | 'xxl' | true

maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Apr 28, 2022
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Apr 28, 2022
maxokorokov added a commit that referenced this issue Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants