-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NgbNavbar is not documented #4462
Closed
jnizet opened this issue
Jan 8, 2023
· 2 comments
· Fixed by #4471 · May be fixed by MrDari/HeroTest#5
Closed
NgbNavbar is not documented #4462
jnizet opened this issue
Jan 8, 2023
· 2 comments
· Fixed by #4471 · May be fixed by MrDari/HeroTest#5
Milestone
Comments
Demo: https://stackblitz.com/edit/angular-pzelbe?file=src%2Fapp%2Fdropdown-navbar.ts Should we import |
Maybe simply replace it with This is literally the only place it is used for: ng-bootstrap/src/dropdown/dropdown.ts Line 260 in 25f2319
This would work just fine: this.display = this._elementRef.nativeElement.closest('.navbar') ? 'static' : 'dynamic'; |
jnizet
added a commit
to jnizet/ng-bootstrap
that referenced
this issue
Jan 20, 2023
The NgbNavbar directive is not removed, but simply deprecated, in order to avoid a breaking change for people who have imported it in their modules or standalone components. fix ng-bootstrap#4462
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description:
For dropdowns to look correctly inside a collapsed navbar, the
NgbNavbar
directive is necessary. It's automatically applied when importingNgbDropdownModule
(because its selector is simply.navbar
), but when using standalone components, it's far from obvious that this directive needs to be imported, since it's not even documented.The text was updated successfully, but these errors were encountered: