feat(dropdown): replace NgbNavbar usage by DOM call to closest() #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NgbNavbar directive is not removed, but simply deprecated, in order to avoid a breaking change for people who have imported it in their modules or standalone components. fix ng-bootstrap#4462
|
Note: I wondered if using a call to closest() would be an issue in a server-side environment, which I don't have any experience with, but Angular Universal now apparently uses domino, which should thus support the call. |
Codecov ReportBase: 88.68% // Head: 88.68% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #4471 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 114 114
Lines 4003 4003
Branches 844 844
=======================================
Hits 3550 3550
Misses 413 413
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NgbNavbar directive is not removed, but simply deprecated, in order to avoid a breaking change for people who have imported it in their modules or standalone components.
fix #4462
Before submitting a pull request, please make sure you have at least performed the following: