Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature-request: Add show and hide outputs to NgbAccordionDirective similar to Bootstrap events #4528

Closed
brianroadifer opened this issue Jun 20, 2023 · 0 comments · Fixed by #4537
Closed

feature-request: Add show and hide outputs to NgbAccordionDirective similar to Bootstrap events #4528

brianroadifer opened this issue Jun 20, 2023 · 0 comments · Fixed by #4537
Labels
component: accordion type: feature
Milestone
15.1.0

Comments

@brianroadifer
Copy link

brianroadifer commented Jun 20, 2023 •
edited
Loading

Hello, I am currently migrating from the NgbAccordion component to the NgbAccordionDirective. With this migration, I noticed that there is no longer a panelChange output and that the only outputs are now, shown and hidden. I was wondering if you can add the show and hide outputs that Bootstrap has as there are scenarios where something will need to occur before the collapse animation. I ask this since the panelChange output was able to do this before animations started and that it would make it equal to what what Bootstrap offers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: accordion type: feature
Projects
None yet
Milestone
15.1.0
Development

Successfully merging a pull request may close this issue.

feat(accordion): add 'show' and 'hide' events maxokorokov/ng-bootstrap
2 participants
@maxokorokov @brianroadifer