Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): add 'show' and 'hide' events #4537

Merged

Conversation

maxokorokov
Copy link
Member

Fixes #4528

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 98.09% and project coverage change: +0.44 🎉

Comparison is base (439aa2a) 88.83% compared to head (71f1dcc) 89.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4537      +/-   ##
==========================================
+ Coverage   88.83%   89.27%   +0.44%     
==========================================
  Files         115      120       +5     
  Lines        4092     4300     +208     
  Branches      774      820      +46     
==========================================
+ Hits         3635     3839     +204     
- Misses        415      419       +4     
  Partials       42       42              
Flag Coverage Δ
e2e 50.14% <5.46%> (-2.23%) ⬇️
unit 89.90% <98.05%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/scrollspy/scrollspy.ts 94.36% <94.36%> (ø)
src/accordion/accordion.directive.ts 97.32% <100.00%> (+0.23%) ⬆️
src/popover/popover.ts 95.12% <100.00%> (+0.06%) ⬆️
src/scrollspy/scrollspy-config.ts 100.00% <100.00%> (ø)
src/scrollspy/scrollspy.module.ts 100.00% <100.00%> (ø)
src/scrollspy/scrollspy.service.ts 100.00% <100.00%> (ø)
src/scrollspy/scrollspy.utils.ts 100.00% <100.00%> (ø)
src/tooltip/tooltip.ts 98.57% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxokorokov maxokorokov merged commit 005290e into ng-bootstrap:master Jul 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature-request: Add show and hide outputs to NgbAccordionDirective similar to Bootstrap events
2 participants