timepicker: add support for arrowkeys and mousewheel #459
Comments
pkozlowski-opensource
changed the title
|
will take this one 👍 |
|
@pkozlowski-opensource, just tested this, it seems to work on the demo. Can probably be closed. |
thbt
pushed a commit
to thbt/ng-bootstrap
that referenced
this issue
Feb 23, 2017
5 tasks
thbt
pushed a commit
to thbt/ng-bootstrap
that referenced
this issue
Mar 28, 2017
thbt
pushed a commit
to thbt/ng-bootstrap
that referenced
this issue
Apr 18, 2017
thbt
pushed a commit
to thbt/ng-bootstrap
that referenced
this issue
Apr 18, 2017
thbt
pushed a commit
to thbt/ng-bootstrap
that referenced
this issue
Apr 18, 2017
|
Looks like this has been in the pipeline for months. Is the PR still in limbo? |
|
@pkozlowski-opensource is there a chance at least keyboard support is added to the timepicker? You chose to close #1334 with the comment "We will pass on this one for now till we figure out what to do with the timepicker...", but I'm not sure what you meant by that. |
jnizet
added a commit
to jnizet/ng-bootstrap
that referenced
this issue
Dec 7, 2018
Mousewheel support is more controversial, and would probably need an additional input + config to enable/disable it, as it's used by users which are not proficient keyboard users to scroll the page. But I think keyboard support is a must, and can be turned on always. refs ng-bootstrap#459
5 tasks
jnizet
added a commit
to jnizet/ng-bootstrap
that referenced
this issue
Dec 7, 2018
Mousewheel support is more controversial, and would probably need an additional input + config to enable/disable it, as it's used by users which are not proficient keyboard users to scroll the page. But I think keyboard support is a must, and can be turned on always. refs ng-bootstrap#459
maxokorokov
pushed a commit
to jnizet/ng-bootstrap
that referenced
this issue
Feb 25, 2019
Mousewheel support is more controversial, and would probably need an additional input + config to enable/disable it, as it's used by users which are not proficient keyboard users to scroll the page. But I think keyboard support is a must, and can be turned on always. refs ng-bootstrap#459
maxokorokov
pushed a commit
that referenced
this issue
Feb 26, 2019
|
Is there any reason to keep the issue opened ? From what I can see in the documentation the arrow keys support is working :) |
|
Last piece closed in #2053. I don't think implementing mouse wheel is a good idea, for example because of accidental scrolls it might introduce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ref: http://angular-ui.github.io/bootstrap/#/timepicker
It should be trivial to implement but needs tests (as always!)
The text was updated successfully, but these errors were encountered: