You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please remember, the issues forum is NOT for support requests. It is for bugs and feature requests only.
Please read https://github.com/ng-bootstrap/ng-bootstrap/blob/master/CONTRIBUTING.md and search
existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.
Bug description:
This is not a bug report, but more like a code refectory.
In e2e-app's playwright global setup function, it actually returns a function, which will run during global teardown, as documented by playwright. I spent quite some time to figure that out.
I think having a more straightforward two separated playwright file, global setup and teardown, would help others understood easier.
I'm happy to pull a PR to do this fix. If I can get an affirmative response first.
Link to minimally-working StackBlitz that reproduces the issue:
You can fork a StackBlitz from one of our demos and use it as a starting point.
Please remember, the issues forum is NOT for support requests. It is for bugs and feature requests only.
Please read https://github.com/ng-bootstrap/ng-bootstrap/blob/master/CONTRIBUTING.md and search
existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.
Bug description:
This is not a bug report, but more like a code refectory.
In e2e-app's playwright global setup function, it actually returns a function, which will run during global teardown, as documented by playwright. I spent quite some time to figure that out.
I think having a more straightforward two separated playwright file, global setup and teardown, would help others understood easier.
I'm happy to pull a PR to do this fix. If I can get an affirmative response first.
Link to minimally-working StackBlitz that reproduces the issue:
You can fork a StackBlitz from one of our demos and use it as a starting point.
Please note that we can not act on bug reports without a minimal reproduction scenario in a StackBlitz. Here is why:
https://github.com/ng-bootstrap/ng-bootstrap#you-think-youve-found-a-bug
Versions of Angular, ng-bootstrap and Bootstrap:
Angular:
ng-bootstrap:
Bootstrap:
The text was updated successfully, but these errors were encountered: