You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NgbDismissibleAlert has a strange name: it implies that regular alerts, i.e. NgbAlerts, are not dismissible, although they are. And bizarrely, NgbDismissibleAlert is always dismissible with a close button, even though the whole point of the directive is to have an alert that self-closes itself after a while, rendering the close button redundant.
We're still in alpha version, so renaming a component is not a big deal.
What I propose:
rename NgbDismissibleAlert to NgbSelfClosingAlert
add a boolean dismissible input to NgbSelfClosingAlert, aligning it with NgbAlert
set its default value to false
The last point is more debatable than the others. I typically use such alerts for sort-lived success messages where the close button is redundant. Maybe others use it for long-lived messages where having the close button by default is better. But anyway, since the default values will soon be customizable globally, that's not a big deal.
The text was updated successfully, but these errors were encountered:
- refactor NgbDismissibleAlert to NgbSelfClosingAlert
- make it possible to hide the close button on self-closing alerts
- make the self-closing alert tests a bit less convoluted
fixng-bootstrap#660
- refactor NgbDismissibleAlert to NgbSelfClosingAlert
- make it possible to hide the close button on self-closing alerts
- make the self-closing alert tests a bit less convoluted
fixng-bootstrap#660
NgbDismissibleAlert has a strange name: it implies that regular alerts, i.e. NgbAlerts, are not dismissible, although they are. And bizarrely, NgbDismissibleAlert is always dismissible with a close button, even though the whole point of the directive is to have an alert that self-closes itself after a while, rendering the close button redundant.
We're still in alpha version, so renaming a component is not a big deal.
What I propose:
The last point is more debatable than the others. I typically use such alerts for sort-lived success messages where the close button is redundant. Maybe others use it for long-lived messages where having the close button by default is better. But anyway, since the default values will soon be customizable globally, that's not a big deal.
The text was updated successfully, but these errors were encountered: