-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: restore full AoT compatibility #854
fix: restore full AoT compatibility #854
Conversation
The fix for AoT from this PR boils down to 2 things:
|
Awesome! Gonna try this later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is AoT compile available for alpha.6? or is it up to alpha.7? |
Awesome! I'm waiting impatiently to try this out :). I tried to install directly from GitHub but I get this error:
Any ideas? I can confirm by inspecting the diffs that you fixed all of my errors with the changes here and here, but I'm not able to test it. Maybe if you published an alpha 7 it would be easier :). @alanpurple: this is not on npm yet, it's supposed to be released on alpha 7. Thanks! |
alpha.7 with aot compatibility will be cut alter today. |
You rock dude! |
For anyone tracking AoT compatibility - I've just pushed alpha.7 to npm so you can download it and take for the test drive. Be sure to check the breaking changes section while updating! The demo site updated to alpha.7 should be up shortly. |
Fixes #796