Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore full AoT compatibility #854

Closed
wants to merge 1 commit into from
Closed

fix: restore full AoT compatibility #854

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

Fixes #796

@pkozlowski-opensource
Copy link
Member Author

The fix for AoT from this PR boils down to 2 things:

@smyth64
Copy link

smyth64 commented Oct 8, 2016

Awesome! Gonna try this later.

Copy link
Member

@icfantv icfantv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanpurple
Copy link

Is AoT compile available for alpha.6? or is it up to alpha.7?

@colltoaction
Copy link

colltoaction commented Oct 10, 2016

Awesome! I'm waiting impatiently to try this out :). I tried to install directly from GitHub but I get this error:

node misc/validate-commit.install.js
fs.js:640
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^
Error: ENOENT: no such file or directory, open '.............\node_modules\ng-bootstrap\.git\hooks\commit-msg'
    at Error (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.fs.writeFileSync (fs.js:1333:33)
    at Object.<anonymous> (.......................\node_modules\ng-bootstrap\misc\validate-commit.install.js:10:6)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.runMain (module.js:590:10)
npm WARN install:ng-bootstrap@1.0.0-alpha.6 ng-bootstrap@1.0.0-alpha.6 install: `node misc/validate-commit.install.js`
npm WARN install:ng-bootstrap@1.0.0-alpha.6 Exit status 1

Any ideas?

I can confirm by inspecting the diffs that you fixed all of my errors with the changes here and here, but I'm not able to test it.

Maybe if you published an alpha 7 it would be easier :). @alanpurple: this is not on npm yet, it's supposed to be released on alpha 7.

Thanks!

@pkozlowski-opensource
Copy link
Member Author

alpha.7 with aot compatibility will be cut alter today.

@colltoaction
Copy link

You rock dude!

@pkozlowski-opensource
Copy link
Member Author

For anyone tracking AoT compatibility - I've just pushed alpha.7 to npm so you can download it and take for the test drive. Be sure to check the breaking changes section while updating! The demo site updated to alpha.7 should be up shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants