-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng-bootstrap causes AOT to fail with module not found errors. #796
Comments
We need to investigate and might need to re-export all directives from |
A (possibly) useful ref: angular/angular#11689 |
@pkozlowski-opensource I already have outdir and gendir that the person suggested in the link... I don't think there is anything wrong in particular settings, as I have material design branch that works just fine...I was trying to add a bootstrap branch to my seed starter project which AOT works otherwise fine with, but this is blocking creating bootstrap branch: https://github.com/qdouble/angular2webpack2-starter |
The most probable suspect: angular/angular#11889 We need to investigate by creating a minimal project that uses ng-bootstrap. |
@pkozlowski-opensource is there something blocking this being fixed or do you need me to create a more minimal repo first? |
@pkozlowski-opensource I just uploaded the bootstrap branch of the starter project that I've been working on: https://github.com/qdouble/angular2webpack2-starter/tree/bootstrap To reproduce the error, after installing. just run |
@qdouble thnx for the repro. There are still a bunch of errors in the AoT on the ng2 side and I want to take time in the coming days to fix them upstream or work-around here (but honestly I would rather prefer fixing stuff in the Angular itself as it will benefit the entire community). |
@qdouble thnx to your repro I could just confirm that we are bumping into angular/angular#11889 (or a slight variation of it). I need to do a bit more testing but I will either check with Tobias to see how far the fix is or will just work-around it for now as we were planning to export things anyway in #779 Thnx for bearing with us, a fix is not far away :-) |
I hope this get fixed soon. ng-bootstrap is the only thing in our projects that's preventing AoT/Universal. If I just knew, where to look at then I could help you guys 🙃 |
@smith64fx AoT is a top priority for us, all hands on the deck :-) I'm pretty positive that we are going to have a fix / workaround by Mon. |
Ha! We've got a fix in #854. It just need review. I'm going to land it and cut a new release as soon as it is reviewed. |
For anyone tracking AoT compatibility - I've just pushed alpha.7 to npm so you can download it and take for the test drive. Be sure to check the breaking changes section while updating! The demo site updated to alpha.7 should be up shortly. |
Bug description:
When I import @ng-bootstrap and run AOT, I get the following errors and more
When I check the compiled files, it appears that many components are not being generated.
Version of Angular, ng-bootstrap, and Bootstrap:
Angular: 2.0.1
ng-bootstrap: 1.0.0-alpha.6
The text was updated successfully, but these errors were encountered: