Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(dropdown): better document:click listener, improving performance #1863

Closed
wants to merge 1 commit into from
Closed

perf(dropdown): better document:click listener, improving performance #1863

wants to merge 1 commit into from

Conversation

MerlierR
Copy link

Before submitting a pull request, please make sure you have at least performed the following:

  • [] read and followed the CONTRIBUTING.md guide.
  • [] built and tested the changes locally.
  • [] added/updated any applicable tests.
  • [] added/updated any applicable API documentation.
  • [] added/updated any applicable demos.

@MerlierR MerlierR changed the title fix(dropdown): better document:click listener, improving performance perf(dropdown): better document:click listener, improving performance Sep 25, 2017
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Jan 12, 2018
Closed
@maxokorokov maxokorokov added this to the 3.0.0 milestone Jul 12, 2018
@maxokorokov
Copy link
Member

Hey, @MerlierR!

Thanks a lot for the time to open the PR, it looks good and we probably should have merged it earlier.
Yours is a valid implementation, however we've gone with observables when implementing closing on ESC and adding outside click to this pipeline seemed a natural fit in #2518.

@pkozlowski-opensource
Copy link
Member

Thnx for the PR but we've decided to merge #2518 instead. Still appreciate all the contributions!

@mboughaba mboughaba mentioned this pull request Dec 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: dropdown type: bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MerlierR @maxokorokov @pkozlowski-opensource