refactor(datepicker): move <select> value binding to lifecycle hook #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3163 +/- ##
==========================================
+ Coverage 90.9% 90.93% +0.03%
==========================================
Files 95 95
Lines 2748 2759 +11
Branches 510 513 +3
==========================================
+ Hits 2498 2509 +11
Misses 190 190
Partials 60 60
Continue to review full report at Codecov.
|
maxokorokov
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In View Engine, directives are updated before property bindings. So elements are created/updated before the [value] binding is set/updated in . In the end, the right option is selected in the browser. In Ivy, things are executed in the reverse order. Setting the value property of a when there is no matching does nothing in a real browser. As a result, the first option is always selected after the first render.