Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(positioning): put the popup in a separate layer #3206

Merged

Conversation

maxokorokov
Copy link
Member

Without forcing the popup in a separate layer, Safari and Firefox are doing a lot more work than necessary.

Example: trying to reposition datepicker 3 times, before finding an optimal position.

Quite significant changes in Safari → removes full page layout and compositing.

Safari Before:

Screen Shot 2019-05-23 at 15 11 59

Safari After:

Screen Shot 2019-05-23 at 15 13 32

In Firefox it removes unnecessary paints as well.


Concerning the The translate3d/gpu acceleration render a blurry text on chrome, the next line is commented until a browser fix → we're not using translate3d, but translate. And it looks fine in Chrome.

Related to #3199

@codecov-io
Copy link

Codecov Report

Merging #3206 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3206      +/-   ##
==========================================
+ Coverage   92.03%   92.04%   +<.01%     
==========================================
  Files          91       91              
  Lines        3052     3053       +1     
  Branches      504      504              
==========================================
+ Hits         2809     2810       +1     
  Misses        179      179              
  Partials       64       64
Flag Coverage Δ
#e2e 63.11% <100%> (+0.01%) ⬆️
#unit 89.47% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/util/positioning.ts 96% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a2d0cc...d5de41b. Read the comment docs.

@fbasso
Copy link
Member

fbasso commented May 27, 2019

Unfortunately, the text is blurry on Chrome/Windows with will-change activated:

Tooltip blurry

@maxokorokov
Copy link
Member Author

Ok, so we've figured out that it happens only on Win10 with some font zoom levels in Chrome. Same issue in Bootstrap itself, so will merge.

@maxokorokov maxokorokov merged commit 2bbaaee into ng-bootstrap:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants