Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): ease the styling of datepicker #3248

Merged
merged 1 commit into from Jul 16, 2019

Conversation

IAfanasov
Copy link
Contributor

  • sets background color in ngb-dp-* classes instead of using .bg-light

closes #3244

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • [] added/updated any applicable tests.
  • [] added/updated any applicable API documentation.
  • [] added/updated any applicable demos.

- sets background color in ngb-dp-* classes instead of using .bg-light

closes ng-bootstrap#3244
@codecov-io
Copy link

Codecov Report

Merging #3248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3248   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files          91       91           
  Lines        3054     3054           
  Branches      505      505           
=======================================
  Hits         2811     2811           
  Misses        179      179           
  Partials       64       64
Flag Coverage Δ
#e2e 62.99% <ø> (ø) ⬆️
#unit 89.47% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/datepicker/datepicker.ts 99% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a17683...ca423db. Read the comment docs.

@IAfanasov
Copy link
Contributor Author

@benouat ! thanks for review!
I see approval and 'needs: review' tag. Confusing (:

@benouat benouat merged commit dd86266 into ng-bootstrap:master Jul 16, 2019
gpolychronis pushed a commit to gpolychronis/ng-bootstrap that referenced this pull request Sep 5, 2019
@IAfanasov IAfanasov deleted the feature/datepicker-css branch April 20, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "bg-light" css class from the datepicker component
3 participants