Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): upgrade z-index for backdrop #4243

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

fbasso
Copy link
Member

@fbasso fbasso commented Feb 9, 2022

fix #4139

@fbasso fbasso changed the title Backdrop fix(modal): upgrade z-index for backdrop Feb 9, 2022
@fbasso fbasso changed the base branch from master to bootstrap5 February 9, 2022 10:30
@codecov-commenter
Copy link

Codecov Report

Merging #4243 (6365dd4) into bootstrap5 (65ba6c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           bootstrap5    #4243   +/-   ##
===========================================
  Coverage       88.24%   88.24%           
===========================================
  Files             111      111           
  Lines            3573     3573           
  Branches          674      674           
===========================================
  Hits             3153     3153           
  Misses            372      372           
  Partials           48       48           
Flag Coverage Δ
e2e 46.14% <ø> (ø)
unit 88.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modal/modal-backdrop.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ba6c3...6365dd4. Read the comment docs.

@fbasso fbasso merged commit fc84cb1 into ng-bootstrap:bootstrap5 Feb 9, 2022
@fbasso fbasso deleted the backdrop branch February 9, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backdrop does not work on stacked modal
4 participants