-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Navigation links do not work when using baseHref #34
Comments
Good catch thanks! I'll fix it right now |
🎉 This issue has been resolved in version 15.7.10 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thanks for the quick fix, but I think using |
And even if I change the API scope name, links generated from markdown (e.g. to API pages) do not work when opening them in a new tab |
Ah I see, ok let me think about a better solution maybe I will be able to prepare HTML and update |
I found a solution that I had considered during development but decided against because I thought it was unnecessary. However, now I see that it is necessary. The problem was that although the handler used Angular Router, when hovering over a link, an incorrect address was still displayed because the actual address in the I removed the code in I could have modified these links on the builder side, but that wouldn't have solved the problem of click handling in Solution:
|
## [15.7.11](v15.7.10...v15.7.11) (2023-03-22) ### Bug Fixes **app:** navigation links do not work when using baseHref([41f4c3f](41f4c3f)), closes[#34](#34)
🎉 This issue has been resolved in version 15.7.11 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sry, I added another fix, I forgot about links in code examples and demos that are generated based on keywords |
## [15.7.12](v15.7.11...v15.7.12) (2023-03-22) ### Bug Fixes **app:** navigation links in code examples do not work when using baseHref([12280d0](12280d0)), closes[#34](#34)
🎉 This issue has been resolved in version 15.7.12 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Looks good. Thank you! |
Is this a regression?
I don't know
Description
When I build my ng-doc app with
ng build --base-href=/my-site/
(for publishing to GitHub Pages) or setbaseHref
option in angular.json and run it withng serve
, the navigation links (in both the left menu and next/prev) throw the following error. The routes work correctly if I enter the URL directly into the browser. Links that were generated from markdown display the wrong URL on hover, but work correctly when I click on them.Please provide the exception or error you saw
OS
Unix (Linux, macOS, etc.)
Browser
Chrome
Node version
18.12.1
Anything else?
No response
The text was updated successfully, but these errors were encountered: