Skip to content

Commit

Permalink
fix: emit TypeScript declaration diagnostics
Browse files Browse the repository at this point in the history
Previously, declaration diagnostics were not emitted which caused certain compilation errors not to be emitted.

Closes #2405

(cherry picked from commit 98f4de9)
  • Loading branch information
alan-agius4 committed Aug 31, 2022
1 parent 2f179c7 commit 2176bd9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/lib/ngc/compile-source-files.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export async function compileSourceFiles(
for (const sourceFile of builder.getSourceFiles()) {
if (!ignoreForDiagnostics.has(sourceFile)) {
allDiagnostics.push(
...builder.getDeclarationDiagnostics(sourceFile),
...builder.getSyntacticDiagnostics(sourceFile),
...builder.getSemanticDiagnostics(sourceFile),
);
Expand Down

0 comments on commit 2176bd9

Please sign in to comment.