Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update watch version on secondary entrypoint changes #2379

Merged
merged 1 commit into from Jul 18, 2022
Merged

fix: update watch version on secondary entrypoint changes #2379

merged 1 commit into from Jul 18, 2022

Conversation

Carlosamouco
Copy link

@Carlosamouco Carlosamouco commented Jul 16, 2022

closes #2069

I'm submitting a...

[X] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

Currently, when a secondary entrypoint emits new changes, the package.json version of the primary entrypint is not updated, making linked libraries changes undetected by webpack.

With this change, we update the main entrypoint package.json version whenever a secondary entrypoint recompiles in watch mode.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@alan-agius4
Copy link
Member

Secondary entry-points no longer have a package.json in version 14.

@Carlosamouco
Copy link
Author

Secondary entry-points no longer have a package.json in version 14.

That's why we need to update the package.json version of the primary entrypoint when we are recompiling a secondary entrypoint, right?

@alan-agius4
Copy link
Member

Oh gosh you are right.

Copy link
Member

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@alan-agius4 alan-agius4 merged commit 1280320 into ng-packagr:main Jul 18, 2022
@Carlosamouco Carlosamouco changed the title fix: update watch version on secundary entrypoint changes fix: update watch version on secondary entrypoint changes Jul 18, 2022
@github-actions
Copy link

This PR has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Secondary entrypoints updates not applied when using npm link
2 participants