Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lib.externals support. #57

Merged
merged 1 commit into from
Jun 24, 2017
Merged

Conversation

aitboudad
Copy link
Contributor

fix #49 and #56.

@dherges
Copy link
Contributor

dherges commented Jun 23, 2017

Hi @aitboudad,

thanks for your effort!

I will look at it at the latest on monday and then publish another pre-release!

First impression: looks good! Tests are still green! Thank you!

@dherges
Copy link
Contributor

dherges commented Jun 24, 2017

Yes, fantastic!

Thanks @aitboudad! 🌟

@dherges dherges merged commit c226972 into ng-packagr:master Jun 24, 2017
@aitboudad aitboudad deleted the externals branch June 25, 2017 06:09
@aitboudad
Copy link
Contributor Author

Thanks!

@github-actions
Copy link

This PR has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

lib.externals being ignored
2 participants