Remove unneeded check

ng-select · Sep 25, 2017 · 16662c2 · 16662c2
1 parent 289c73a
commit 16662c2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/lib/src/items-list.ts b/src/lib/src/items-list.ts
@@ -25,9 +25,6 @@ export class ItemsList {
     }
 
     select(item: NgOption): boolean {
-        if (this._selected.indexOf(item) > -1) {
-            return false;
-        }
         if (!this._multiple) {
             this.clearSelected();
         }

diff --git a/src/lib/src/ng-select.component.ts b/src/lib/src/ng-select.component.ts
@@ -260,9 +260,12 @@ export class NgSelectComponent implements OnInit, ControlValueAccessor {
     }
 
     select(item: NgOption) {
-        if (this.itemsList.select(item)) {
-            this.updateModel();
+        if (item.selected) {
+            return;
         }
+
+        this.itemsList.select(item);
+        this.updateModel();
         if (!this.multiple) {
             this.close();
         }