scrollToEnd is fired when typeahead is present before reaching scroll end

[neil-coutinho]

Describe the bug

If you have a typeahead present the scrollToEnd is fired even before you reach the bottom of the options.

Reproducbile example
StackBlitz which reproduces described behaviour

To Reproduce
Steps to reproduce the behavior (if example is not provided):

1. Open the dropdown (It loads with a set of options)

2. Scroll down to the 2nd option

3. Now type something in the search box, you will see that after the typeahead subject emits a value the scrollToEnd event is fired as well

Expected behavior
ScrollToEnd should only fire if the user has reached the end of the list. Not when the list is reset or updated

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [Mac OS]
• Browser [Chrome]

[anjmao]

@neil-coutinho Thanks for a good catch. This happens because after you scrolled to to second item ng-select checks if last item is reached and as you later type in search and only few items are visible it fires that event. Probably the simplest fix would be to reset fire to end flag if items changed https://github.com/ng-select/ng-select/blob/master/src/ng-select/ng-dropdown-panel.component.ts#L122

[janstadt]

We're seeing that with this change we're not seeing the event being fired due to a rounding issue.

Thoughts on rounding up here?

if (ceil(scrollTop + this._dropdown.clientHeight) >= padding.clientHeight) { ... }

[nrcdmovliaiko]

any updates?

[chzeeshansaleem]

i have faced this same issue how to solve it.