Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi select change event #102

Closed
siddharth1903 opened this issue Oct 24, 2017 · 3 comments
Closed

Multi select change event #102

siddharth1903 opened this issue Oct 24, 2017 · 3 comments
Assignees
@varnastadeus
Labels
bug

Comments

@siddharth1903
Copy link

siddharth1903 commented Oct 24, 2017 •
edited

Hi, I have a query... I have a custom auto complete implementation on multi select. I'm noticing the following behaviour for change event.. When we just type in something random and click outside the select box, it correctly clears out the text in the input , but also fires the change event. Is it necessary to fire the change event in this case as no tag was added or dropped.
@siddharth1903
Copy link
Author

Might be related to #91

@siddharth1903
Copy link
Author

siddharth1903 commented Oct 25, 2017 •
edited

@anjmao Whats your take on this?

@anjmao
Copy link
Member

anjmao commented Oct 26, 2017

@Goonersid That is a good catch! It should not fire change event on this case. I hope I will fix it this week :)

@anjmao anjmao added the bug label Oct 26, 2017
@varnastadeus varnastadeus self-assigned this Oct 27, 2017
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
@varnastadeus
fix: don't fire change event on blur
7fea136 
fixes ng-select#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varnastadeus varnastadeus

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anjmao @varnastadeus @siddharth1903