[Bug] Dropdown position not always correctly updated with virtual scrolling #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@varnastadeus Could I please get a comment on this? :) |
|
Yes this PR is very critical, as I am using too and it is very common to have greater amount of entries and virtual scrolling is required. One of a common practiced in the usage of select is to keep the list between 3 - 12. Hence a virtual scroll and a search box will come in handy. Hence there is a need to have the virtual scrolling to works correctly. |
EricsG95
approved these changes
Apr 30, 2019
saeedarshad
approved these changes
May 2, 2019
|
Can we do anything to move this forward? We're still running on a fork due to this issue :-/ |
Merged
|
closing in favor #1188 |
varnastadeus
added a commit
that referenced
this pull request
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dropdown of the multi-select is not always correctly positioned when the virtual scrolling is enabled. This happens because there is a case in which the promise after updating the list items is not resolved. Thus the list position is not updated.
https://stackblitz.com/edit/angular-hxjvkx