Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change event fires without value change - multi select #126

Closed
siddharth1903 opened this issue Nov 15, 2017 · 1 comment · Fixed by #130
Closed

Change event fires without value change - multi select #126

siddharth1903 opened this issue Nov 15, 2017 · 1 comment · Fixed by #130
Assignees
@varnastadeus
Labels
bug

Comments

@siddharth1903
Copy link

I have a type ahead dropdown with multi select enabled... When i type in a few characters like 'test' and hit the X or close button, the change event fires..

Expected behaviour

Change event needs to fire only when the value has changed, i.e tag added or dropped

Actual behaviour

change event fires
@anjmao
Copy link
Member

anjmao commented Nov 16, 2017

@Goonersid thanks for reporting :)

@anjmao anjmao added the bug label Nov 16, 2017
@anjmao anjmao added this to the Version 1.0.0 milestone Nov 16, 2017
@varnastadeus varnastadeus self-assigned this Nov 19, 2017
varnastadeus added a commit that referenced this issue Nov 19, 2017
@varnastadeus
fix(events): don't fire change event on search clear
a56f238 
fixes #126
@varnastadeus varnastadeus mentioned this issue Nov 19, 2017
Merged
anjmao pushed a commit that referenced this issue Nov 20, 2017
@varnastadeus @anjmao
fix(events): don't fire change event on search clear (#130)
8bc8b8e 
* fix(events): don't fire change event on search clear
fixes #126
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
@varnastadeus @anjmao
fix(events): don't fire change event on search clear (ng-select#130)
b37bfee 
* fix(events): don't fire change event on search clear
fixes ng-select#126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varnastadeus varnastadeus

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(events): don't fire change event on search clear ng-select/ng-select
3 participants
@anjmao @varnastadeus @siddharth1903