Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(events): don't fire change event on search clear #130

Merged
merged 3 commits into from
Nov 20, 2017
Merged

fix(events): don't fire change event on search clear #130

merged 3 commits into from
Nov 20, 2017

Conversation

varnastadeus
Copy link
Member

fixes #126

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 88.223% when pulling a56f238 on change-event into 767831e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 88.21% when pulling dee2625 on change-event into 767831e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 88.21% when pulling dee2625 on change-event into 767831e on master.

@anjmao anjmao merged commit 8bc8b8e into master Nov 20, 2017
@anjmao anjmao deleted the change-event branch November 20, 2017 16:28
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@varnastadeus @anjmao
fix(events): don't fire change event on search clear (ng-select#130)
b37bfee 
* fix(events): don't fire change event on search clear
fixes ng-select#126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjmao anjmao anjmao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change event fires without value change - multi select
3 participants
@varnastadeus @coveralls @anjmao