Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search terms highlighted (improvement) #152

Closed
rgiosa opened this issue Dec 3, 2017 · 3 comments
Closed

Search terms highlighted (improvement) #152

rgiosa opened this issue Dec 3, 2017 · 3 comments
Labels
good for contribution improvement

Comments

@rgiosa
Copy link

rgiosa commented Dec 3, 2017

It would be interesting to have the option of the search result having the search terms highlighted.

Finally a component that works! Thank you!
@anjmao
Copy link
Member

anjmao commented Dec 3, 2017

@rgiosa Thanks for suggestion. This is indeed a good feature to add to the list :)

@anjmao anjmao added this to the Version 2.0.0 milestone Dec 3, 2017
@benjaminlefevre
Copy link
Contributor

Would be nice to have this functionality!

@benjaminlefevre benjaminlefevre mentioned this issue Feb 3, 2018
Merged
@anjmao anjmao closed this as completed in 493c349 Feb 6, 2018
@rgiosa
Copy link
Author

rgiosa commented Feb 6, 2018

Nice! Great work!

jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
@benjaminlefevre @anjmao
feat: highlight search term in labels in dropdown list (ng-select#233)
2236a11 
closes ng-select#152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good for contribution improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rgiosa @anjmao @benjaminlefevre