Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose isLoading for async items loading #205

Closed
marvinosswald opened this issue Jan 24, 2018 · 2 comments
Closed

expose isLoading for async items loading #205

marvinosswald opened this issue Jan 24, 2018 · 2 comments

Comments

@marvinosswald
Copy link
Contributor

marvinosswald commented Jan 24, 2018 •
edited

Feature Request

Could we have isLoading exposed with an getter and setter so i can set the select loading while i fetch all items async at once, which make typeahead unusable.

PR #206

More Info

ng-select version: 0.15.2
@anjmao
Copy link
Member

anjmao commented Jan 24, 2018

@marvinosswald Thanks for contribution, I was thinking about this feature, but didn't found time to figure out good solution, yours looks good, just added few comments.

@anjmao anjmao closed this as completed in cd3dec1 Jan 25, 2018
@anjmao
Copy link
Member

anjmao commented Jan 25, 2018

@marvinosswald I added example and simplified code #208

jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
@marvinosswald @anjmao
feat: using a getter/setter for isLoading which enables exposing the …
cecae14 
…same and having a change emitter (ng-select#206)

closes ng-select#205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marvinosswald @anjmao