Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touched is not set when Mouse clicking into Select #225

Closed
distributedlock opened this issue Feb 2, 2018 · 1 comment · Fixed by #228
Closed

Touched is not set when Mouse clicking into Select #225

distributedlock opened this issue Feb 2, 2018 · 1 comment · Fixed by #228
Assignees
@anjmao
Labels
bug simple

Comments

@distributedlock
Copy link
Contributor

distributedlock commented Feb 2, 2018 •
edited

No description provided.

@distributedlock distributedlock changed the title Request: Set Touched on Clicking into Select Set Touched on Clicking into Select Feb 2, 2018
@distributedlock distributedlock changed the title Set Touched on Clicking into Select Touched is not set when Mouse clicking into Select Feb 2, 2018
@anjmao
Copy link
Member

anjmao commented Feb 2, 2018

@ranadeeppolavarapu Thanks for reporting. Indeed I was able to reproduce it. It should be a quick fix and probably will be fixed today.

@anjmao anjmao self-assigned this Feb 2, 2018
@anjmao anjmao added the bug label Feb 2, 2018
@anjmao anjmao added this to the Version 1.0.0 milestone Feb 2, 2018
@anjmao anjmao mentioned this issue Feb 2, 2018
Merged
@anjmao anjmao added the simple label Feb 2, 2018
anjmao added a commit that referenced this issue Feb 2, 2018
@anjmao
fix: add touched on dropdown open (#228)
7c5748e 
fixes #225
@distributedlock distributedlock mentioned this issue Feb 3, 2018
Merged
anjmao pushed a commit that referenced this issue Feb 4, 2018
@anjmao
fix: setTouched on Select Close instead of Open (#231)
50a2e3c 
closes #225 
This will set `touched` on closing the option instead of open.
A typical HTML Select in Angular will set touched once the user
mouse clicks out or tabs (keyboard) out. This will emulate that
same behaviour. Setting `touched` right away on open causes
weird user experience when displaying error message that 
typically depend on `touched` being set. We want to let
the user interact with the select and once done interaction,
it is to be set `touched`.
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
@anjmao
fix: add touched on dropdown open (ng-select#228)
f89f1a1 
fixes ng-select#225
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
@anjmao
fix: setTouched on Select Close instead of Open (ng-select#231)
c57739d 
closes ng-select#225 
This will set `touched` on closing the option instead of open.
A typical HTML Select in Angular will set touched once the user
mouse clicks out or tabs (keyboard) out. This will emulate that
same behaviour. Setting `touched` right away on open causes
weird user experience when displaying error message that 
typically depend on `touched` being set. We want to let
the user interact with the select and once done interaction,
it is to be set `touched`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anjmao anjmao

Labels
bug simple
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add touched on dropdown open ng-select/ng-select
2 participants
@anjmao @distributedlock