fix: setTouched on Select Close instead of Open #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will set `touched` on closing the option instead of open. A typical HTML Select in Angular will set touched once the user mouse clicks out or tabs (keyboard) out. This will emulate that same behaviour. Setting `touched` right away on open causes weird user experience when displaying error message that typically depend on `touched` being set. We want to let the user interact with the select and once done interaction, it is to be set `touched`.
|
@ranadeeppolavarapu if you have |
anjmao
approved these changes
Feb 4, 2018
There was a problem hiding this comment.
Looks good, @ranadeeppolavarapu thanks :) I released 0.17.1 version to npm.
@varnastadeus Yes, but it will be set to touched ones dropdown is closed by clicking outside of dropdown or using tab.
jakemdunn
pushed a commit
to jakemdunn/ng-select
that referenced
this pull request
Oct 16, 2018
closes ng-select#225 This will set `touched` on closing the option instead of open. A typical HTML Select in Angular will set touched once the user mouse clicks out or tabs (keyboard) out. This will emulate that same behaviour. Setting `touched` right away on open causes weird user experience when displaying error message that typically depend on `touched` being set. We want to let the user interact with the select and once done interaction, it is to be set `touched`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will set
touchedon closing the option instead of open.A typical HTML Select in Angular will set touched once the user
mouse clicks out or tabs (keyboard) out. This will emulate that
same behaviour. Setting
touchedright away on open causesweird user experience when displaying error message that
typically depend on
touchedbeing set. We want to letthe user interact with the select and once done interaction,
it is to be set
touched.PR Closes #225. A modification to the change in PR #228.
Would greatly appreciate if you can include in this a new version or recut version
0.17.0with this included this PR is accepted. Awesome job on this great library 馃憤/cc @anjmao