-
-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notFoundText shouldn't be displayed when loading async data #243
Labels
Comments
@shyamal890 Thanks for reporting, good catch! |
This line here is missing some logic https://github.com/ng-select/ng-select/blob/master/src/ng-select/ng-select.component.ts#L369, need to add check if const empty = this.itemsList.filteredItems.length === 0;
return (empty && !this._isTypeahead && !this.isLoading) ||
(empty && this._isTypeahead && this.filterValue && !this.isLoading); |
shyamal890
added a commit
to shyamal890/ng-select
that referenced
this issue
Feb 10, 2018
varnastadeus
added a commit
that referenced
this issue
Feb 10, 2018
varnastadeus
added a commit
that referenced
this issue
Feb 10, 2018
jakemdunn
pushed a commit
to jakemdunn/ng-select
that referenced
this issue
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
[loading]
flag is setnotFoundText
shouldn't be triggered as the[items]
array is still waiting to be populated by an async operation.Example Plunker: https://plnkr.co/edit/XU3qdu?p=preview
Checkout the first example.
The text was updated successfully, but these errors were encountered: