Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't show not found text while loading #252

Merged
merged 1 commit into from
Feb 10, 2018
Merged

fix: don't show not found text while loading #252

merged 1 commit into from
Feb 10, 2018

Conversation

varnastadeus
Copy link
Member

fixes #243

@varnastadeus varnastadeus mentioned this pull request Feb 10, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 90.291% when pulling 8c62d53 on loading-fix into cc8607a on master.

@varnastadeus varnastadeus merged commit 6be231a into master Feb 10, 2018
@varnastadeus varnastadeus deleted the loading-fix branch February 10, 2018 16:48
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@varnastadeus
fix: don't show not found text while loading (ng-select#252)
2bbd3b3 
fixes ng-select#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjmao anjmao Awaiting requested review from anjmao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

notFoundText shouldn't be displayed when loading async data
2 participants
@varnastadeus @coveralls