Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More than one ng-select are opened with the arrow button click #289

Closed
Filini opened this issue Feb 26, 2018 · 2 comments
Closed

More than one ng-select are opened with the arrow button click #289

Filini opened this issue Feb 26, 2018 · 2 comments
Assignees
Labels

Comments

@Filini
Copy link

Filini commented Feb 26, 2018

Expected behaviour

When clicking the ng-select arrow to open it, the other ng-select dropdowns should close. Only one ng-select should be open at any given time. The behaviour is correctly implemented when the ng-select is opened by field focus.

Actual behaviour

More than one ng-select stays open, when opening them with the arrow button.

More Info

ng-select version: 0.22.0

browser: Chrome

reproducible in demo page: YES

@anjmao
Copy link
Member

anjmao commented Feb 26, 2018

@Filini Thanks for reporting. This happens because this line of this line here https://github.com/ng-select/ng-select/blob/master/src/ng-select/ng-select.component.ts#L471

As arrow button is inside select rect it is skipped. Need to check if it is possible to check if target is actually arrow btn and exclude it then.

@anjmao anjmao added the bug label Feb 26, 2018
@varnastadeus varnastadeus self-assigned this Feb 26, 2018
varnastadeus added a commit that referenced this issue Feb 27, 2018
@anjmao anjmao closed this as completed in 66a0a8c Feb 27, 2018
@Filini
Copy link
Author

Filini commented Mar 6, 2018

thank you

jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants