Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marked item loops infinetly #361

Closed
anjmao opened this issue Mar 15, 2018 · 0 comments · Fixed by #363
Closed

Marked item loops infinetly #361

anjmao opened this issue Mar 15, 2018 · 0 comments · Fixed by #363
Assignees
@varnastadeus
Labels
bug

Comments

@anjmao
Copy link
Member

anjmao commented Mar 15, 2018

Please fill below information if issuing a bug report.

Expected behaviour

Break loop if all items are checked

Actual behaviour

https://github.com/ng-select/ng-select/blob/master/src/ng-select/items-list.ts#L206

  1. http://localhost:8080/#/bindings Example first select.
  2. Search Pavilnys
  3. Click arrow down
  4. It will be selected and max call stack is reached
@anjmao anjmao added the bug label Mar 15, 2018
@varnastadeus varnastadeus added this to the Version 1.0.0 milestone Mar 15, 2018
@varnastadeus varnastadeus self-assigned this Mar 16, 2018
varnastadeus added a commit that referenced this issue Mar 16, 2018
@varnastadeus
fix: break loop while marking items
fc6cee5 
fixes #361
@varnastadeus varnastadeus mentioned this issue Mar 16, 2018
Merged
varnastadeus added a commit that referenced this issue Mar 17, 2018
@varnastadeus
fix: break loop while marking items (#363)
9888981 
fixes #361
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
@varnastadeus
fix: break loop while marking items (ng-select#363)
f23e7a4 
fixes ng-select#361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varnastadeus varnastadeus

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: break loop while marking items ng-select/ng-select
2 participants
@anjmao @varnastadeus