Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA role: dropdown incorrect #403

Closed
iantrudell opened this issue Mar 30, 2018 · 1 comment
Closed

ARIA role: dropdown incorrect #403

iantrudell opened this issue Mar 30, 2018 · 1 comment
Assignees

Comments

@iantrudell
Copy link

role: "dropdown" throws an Accessibility error in Chrome's Lighthouse audits, perhaps it should be role: "combobox" instead?

In ng-select.js, ng-select.umd.js, ng-select.umd.min.js

Expected behaviour

host: {
'role': 'combobx',
'class': 'ng-select',
'[class.ng-single]': '!multiple',
}

Actual behaviour

host: {
'role': 'dropdown',
'class': 'ng-select',
'[class.ng-single]': '!multiple',
}

@varnastadeus varnastadeus self-assigned this Mar 31, 2018
@esoyke
Copy link

esoyke commented May 25, 2018

Why was this closed? I see the same error reported from the aXe dev tool, 'dropdown' isn't a valid role.

EDIT for future readers: I see accessibility issues were addressed in v2.0.0.

jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants