Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change detection issue when the last item is deselected in multiselect mode #496

Closed
ghost opened this issue Apr 24, 2018 · 3 comments
Closed
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Apr 24, 2018

  1. Go to https://ng-select.github.io/ng-select#/multiselect.
  2. In "Hide selected elements" demo select all items.
  3. Deselect any item.
  4. The dropdown should appear but it doesn't.
  5. Deselect one more item. The dropdown will appear with two elements.

Note: if closeOnSelect is false the issue is more obvious.

More Info

ng-select version: 1.1.4
browser: Google Chrome
reproducible in demo page: Yes.

@ghost ghost changed the title Change detection issue when the last item is deselected multiselect mode Change detection issue when the last item is deselected in multiselect mode Apr 24, 2018
@anjmao
Copy link
Member

anjmao commented Apr 25, 2018

@Maxkorz Hi,
Thanks for reporting, good catch.

@anjmao anjmao added the bug label Apr 25, 2018
@varnastadeus
Copy link
Member

varnastadeus commented Apr 25, 2018

@anjmao In this case I don't think it should open at all, and it worked that way before.

@ghost
Copy link
Author

ghost commented Apr 25, 2018

@varnastadeus looks like $event.stopPropagation() doesn't work. But that's not the issue here.

@varnastadeus varnastadeus self-assigned this May 1, 2018
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants